Merge branch 'main' into val_test_3

midas-network · Apr 22, 2024 · 2b4d0b2 · 2b4d0b2
2 parents f54dd50 + 08d872f
commit 2b4d0b2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/.github/workflows/validation.yml b/.github/workflows/validation.yml
@@ -50,7 +50,6 @@ jobs:
           env:
             GH_PR_NUMBER: ${{ github.event.pull_request.number }}
             GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-            GH_COMMIT_SHA: "none"
 
         - name: Run Validation - Synchronize
           if: ( github.event.action == 'synchronize' )

diff --git a/code/validation.R b/code/validation.R
@@ -3,16 +3,15 @@ library(gh)
 library(dplyr)
 
 # Check if validation need to run
-print(length(Sys.getenv("GH_COMMIT_SHA")))
+print(nchar(Sys.getenv("GH_COMMIT_SHA")))
 
-if (length(Sys.getenv("GH_COMMIT_SHA")) > 1) {
+if (nchar(Sys.getenv("GH_COMMIT_SHA")) > 1) {
   test <- gh::gh(paste0("GET /repos/",
                         "midas-network/example_round-scenariohub/commits/",
                         Sys.getenv("GH_COMMIT_SHA")))
   check <- grepl("data-processed/", unique(unlist(purrr::map(test$files,
                                                              "filename"))))
 } else {
-  print(Sys.getenv("GH_COMMIT_SHA"))
   check <-  TRUE
 }