Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSI-PROF COVID rnd 18 submission #278

Merged
merged 1 commit into from
May 9, 2024

Conversation

jturtle
Copy link
Contributor

@jturtle jturtle commented May 8, 2024

Description

Initial submission to the round 18 scenario.

Notes to repo administrator

This submission contains only 'inc hosp'. This is intentional. We have a number of small details we would like to address—including adding 'inc death', but this update is at least two days away, and probably will come next week. These small changes will not qualitatively change how the scenarios relate to each other in our model. This submission passes all validation tests not related to the presence of 'inc death'.


If this is a new team submission, please include the following details :-

  • Team name: PSI
  • Model Name: PROF
  • Institution: Predictive Science Inc

If you are adding new scenarios to an existing model, please include the following details:-

  • Team name: PSI
  • Model name that is being updated: PROF

Checklist

  • Specify a proper PR title with your team name.
  • All validation checks ran successfully on your branch. Instructions to run the tests locally is present here.

Copy link

github-actions bot commented May 8, 2024

Run validation on files: 2024-04-28-PSI-PROF.gz.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

🟡 Warning 5043: All values associated with output type 'sample' should have a maximum of 1 decimal place

Target Columns:

❌ Error 602: The data frame does not contain projections for 'inc death' target(s).
🟡 Warning 602: No value found associated with the targets: inc death (optional), inc hosp (optional), cum death (optional), cum hosp (optional); output_type: quantile, mean.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

No errors or warnings found on Age_group

@LucieContamin
Copy link
Collaborator

Hi @jturtle,

Thank you for your submission, I just wanted to verify that I understand correctly the sample ID numbering: there is no stochasticity, every models runs has a different run_grouping "grouped" by age_group, horizon and scenario_id. Is that correct?
Also, I was wondering if it possible to round your value column to have a maximum of 1 decimal place, if possible in your next update (it is not necessary to fix it now).

Please let me know if any issues or questions,
Best, Lucie

@jturtle
Copy link
Contributor Author

jturtle commented May 9, 2024 via email

@jturtle
Copy link
Contributor Author

jturtle commented May 9, 2024 via email

@LucieContamin
Copy link
Collaborator

Hi @jturtle ,

Thanks for the quick answer and the additional information. We are using all 1 to imply that there is no stochasticity. So maybe to avoid confusion, would it be possible to use a different number for each stochastic run in your next update (it's ok for this version)? We know this won't change the interpretation of the results, but we just want to be consistent to avoid misinterpretation in the future.

Please let me know if any issues or questions,
Best, Lucie

@LucieContamin LucieContamin merged commit 3ba5e95 into midas-network:master May 9, 2024
1 check failed
@jturtle
Copy link
Contributor Author

jturtle commented May 10, 2024 via email

@LucieContamin
Copy link
Collaborator

Good morning Jamie,

Thank you for your questions, these columns can be difficult to fill in and you ask a very good question.
The "stochastic run" column is here to differentiate multiple stochastic runs in your model run.

So for example, if you have a run that consists of all of the horizons, age and scenario (your example (1)) associated with a single parameter set and sharing the same random seed. Then you can have both run_grouping and stochastic_run with the same numbering, with the group id matching the stochastic id as you say.

If you have a model run that generates all of the horizon and ages for a single scenario ((2)), and do 6 model runs with the same parameter but different stochasticity for each run, then each group can have a different stochastic ids.

Just to add more information and avoid confusion, the difference between (1) and (2) comes down to whether you thinks individual trajectories for different scenarios are directly comparable (because of their stochasticity)

The example (3): stochasticity is independent of parameters, will not be accepted in our validation system. It is expected that at least the horizion and age are grouped together.

Also, just to add more context, this numbering system mostly depends on how you want us to interpret your results. If you think that some groups have the "same" stochasticity, they should match and if not, they shouldn't.

Does that answer your question?

Let me know if you need more information.
I am always happy to answer any questions, and following this exchange, I am also
happy to update the documentation accordingly, if necessary.

Best,
Lucie

@jturtle
Copy link
Contributor Author

jturtle commented May 10, 2024 via email

@LucieContamin
Copy link
Collaborator

Hi Jamie,

That sounds good, thank you very much!
Let me know if you need more information or have any issues, questions!

Best, Lucie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants