Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW (#8): Ability to apply grid field capability to pages via DataExtension #9

Merged
merged 2 commits into from
Apr 27, 2017

Conversation

patricknelson
Copy link
Contributor

Following up on #8. The basic approach here is to migrate core functionality to a trait so that this module's functionality can be applied via either:

  1. Standard PHP class extension
  2. Using SilverStripe's extensions (invented before PHP's native trait implementation)

In this case it does technically change the minimum requirements to support trait so that we can share our own functionality between two totally different classes (Page and DataExtensions) for a similar reason; to keep things DRY. As a result I've had to change the following things:

  • Migrated core code from GridFieldPage to a new trait and including via require_once since SilverStripe 3.x's autoloader doesn't support traits (probably due to their PHP 5.3 compatibility).
  • Updated composer.json requirements to reflect the new PHP requirements
  • Updated README.md to call this out as well

Maybe this change would bump the current module version up to 2.0 instead of 1.0 since technically this is a breaking change in case anyone out there is somehow still on PHP 5.3? 🤔

@micschk micschk merged commit 8182d71 into micschk:master Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants