NEW (#8): Ability to apply grid field capability to pages via DataExtension #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #8. The basic approach here is to migrate core functionality to a trait so that this module's functionality can be applied via either:
trait
implementation)In this case it does technically change the minimum requirements to support
trait
so that we can share our own functionality between two totally different classes (Page
andDataExtensions
) for a similar reason; to keep things DRY. As a result I've had to change the following things:GridFieldPage
to a new trait and including viarequire_once
since SilverStripe 3.x's autoloader doesn't support traits (probably due to their PHP 5.3 compatibility).composer.json
requirements to reflect the new PHP requirementsREADME.md
to call this out as wellMaybe this change would bump the current module version up to
2.0
instead of1.0
since technically this is a breaking change in case anyone out there is somehow still on PHP 5.3? 🤔