-
Notifications
You must be signed in to change notification settings - Fork 50
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: resolve trimming warnings in project
- Loading branch information
Andrew Omondi
committed
Sep 4, 2024
1 parent
277727e
commit ea690d3
Showing
11 changed files
with
239 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,12 +40,12 @@ jobs: | |
|
||
- name: Install needed dotnet workloads | ||
run: dotnet workload install android macos ios maccatalyst | ||
|
||
- name: Restore nuget dependencies | ||
run: dotnet restore ${{ env.solutionName }} | ||
|
||
- name: Lint the code | ||
run: dotnet format --verify-no-changes | ||
|
||
- name: Restore nuget dependencies | ||
run: dotnet restore ${{ env.solutionName }} | ||
|
||
- name: Build | ||
run: dotnet build ${{ env.solutionName }} -c Debug /p:UseSharedCompilation=false,IncludeMauiTargets=true | ||
|
@@ -56,4 +56,17 @@ jobs: | |
- name: Perform CodeQL Analysis | ||
uses: github/codeql-action/analyze@v3 | ||
|
||
validate-trimming: | ||
name: Validate Project for Trimming | ||
runs-on: windows-latest | ||
steps: | ||
- uses: actions/[email protected] | ||
|
||
- name: Setup .NET | ||
uses: actions/setup-dotnet@v4 | ||
with: | ||
dotnet-version: 8.x | ||
|
||
- name: Validate Trimming warnings | ||
run: dotnet publish -c Release -r win-x64 /p:TreatWarningsAsErrors=true /warnaserror -f net8.0 | ||
working-directory: ./tests/Microsoft.Graph.DotnetCore.Core.Trimming |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 78 additions & 0 deletions
78
tests/Microsoft.Graph.DotnetCore.Core.Test/Mocks/MockUploadSessionWithoutInterface.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
namespace Microsoft.Graph.DotnetCore.Core.Test.Mocks | ||
{ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Linq; | ||
using Microsoft.Kiota.Abstractions.Serialization; | ||
|
||
/// <summary> | ||
/// Concrete implementation of the IUploadSession interface | ||
/// </summary> | ||
internal class MockUploadSessionWithoutUploadSessionInterface : IParsable, IAdditionalDataHolder | ||
{ | ||
/// <summary> | ||
/// Expiration date of the upload session | ||
/// </summary> | ||
public DateTimeOffset? ExpirationDateTime | ||
{ | ||
get; set; | ||
} | ||
|
||
/// <summary> | ||
/// The ranges yet to be uploaded to the server | ||
/// </summary> | ||
public List<string> NextExpectedRanges | ||
{ | ||
get; set; | ||
} | ||
|
||
/// <summary> | ||
/// The URL for upload | ||
/// </summary> | ||
public string UploadUrl | ||
{ | ||
get; set; | ||
} | ||
|
||
/// <summary> | ||
/// Stores additional data not described in the OpenAPI description found when deserializing. Can be used for serialization as well. | ||
/// </summary> | ||
public IDictionary<string, object> AdditionalData { get; set; } = new Dictionary<string, object>(); | ||
|
||
/// <summary> | ||
/// The deserialization information for the current model | ||
/// </summary> | ||
public IDictionary<string, Action<IParseNode>> GetFieldDeserializers() | ||
{ | ||
return new Dictionary<string, Action<IParseNode>>(StringComparer.OrdinalIgnoreCase) | ||
{ | ||
{"expirationDateTime", (n) => { ExpirationDateTime = n.GetDateTimeOffsetValue(); } }, | ||
{"nextExpectedRanges", (n) => { NextExpectedRanges = n.GetCollectionOfPrimitiveValues<string>().ToList(); } }, | ||
{"uploadUrl", (n) => { UploadUrl = n.GetStringValue(); } }, | ||
}; | ||
} | ||
|
||
/// <summary> | ||
/// Serializes information the current object | ||
/// <param name="writer">Serialization writer to use to serialize this model</param> | ||
/// </summary> | ||
public void Serialize(ISerializationWriter writer) | ||
{ | ||
_ = writer ?? throw new ArgumentNullException(nameof(writer)); | ||
writer.WriteDateTimeOffsetValue("expirationDateTime", ExpirationDateTime); | ||
writer.WriteCollectionOfPrimitiveValues<string>("nextExpectedRanges", NextExpectedRanges); | ||
writer.WriteStringValue("uploadUrl", UploadUrl); | ||
writer.WriteAdditionalData(AdditionalData); | ||
} | ||
|
||
/// <summary> | ||
/// Creates a new instance of the appropriate class based on discriminator value | ||
/// <param name="parseNode">The parse node to use to read the discriminator value and create the object</param> | ||
/// </summary> | ||
public static MockUploadSessionWithoutUploadSessionInterface CreateFromDiscriminatorValue(IParseNode parseNode) | ||
{ | ||
_ = parseNode ?? throw new ArgumentNullException(nameof(parseNode)); | ||
return new MockUploadSessionWithoutUploadSessionInterface(); | ||
} | ||
} | ||
} |
Oops, something went wrong.