pr review feedback

microsoftgraph · Aug 30, 2024 · e326ed5 · e326ed5
1 parent 4b47b57
commit e326ed5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/Microsoft.Graph.Core/Tasks/LargeFileUploadTask.cs b/src/Microsoft.Graph.Core/Tasks/LargeFileUploadTask.cs
@@ -75,7 +75,7 @@ internal static IUploadSession ExtractSessionFromParsable(IParsable uploadSessio
                 throw new ArgumentException("The Parsable does not contain the 'uploadUrl' property");
 
             // convert to local type as we don't have the type info for the upload session just that it implements IParsable
-            var uploadSessionStream = KiotaSerializer.SerializeAsStream(CoreConstants.MimeTypeNames.Application.Json, uploadSession, false);// just in case there's a backing store 
+            using var uploadSessionStream = KiotaSerializer.SerializeAsStream(CoreConstants.MimeTypeNames.Application.Json, uploadSession, false);// just in case there's a backing store 
             var uploadSessionJsonNode = new JsonParseNode(JsonDocument.Parse(uploadSessionStream).RootElement);
             return uploadSessionJsonNode.GetObjectValue(UploadSession.CreateFromDiscriminatorValue);
         }

diff --git a/tests/Microsoft.Graph.DotnetCore.Core.Test/Tasks/LargeFileUploadTaskTests.cs b/tests/Microsoft.Graph.DotnetCore.Core.Test/Tasks/LargeFileUploadTaskTests.cs
@@ -27,6 +27,7 @@ public LargeFileUploadTests()
         {
             // register the default serialization instance as the generator would.
             ParseNodeFactoryRegistry.DefaultInstance.ContentTypeAssociatedFactories.TryAdd(CoreConstants.MimeTypeNames.Application.Json, new JsonParseNodeFactory());
+            SerializationWriterFactoryRegistry.DefaultInstance.ContentTypeAssociatedFactories.TryAdd(CoreConstants.MimeTypeNames.Application.Json, new JsonSerializationWriterFactory());
         }
 
         [Fact]