Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update request body area #3441

Open
wants to merge 5 commits into
base: feat/fluent-v9-upgrade
Choose a base branch
from

Conversation

ElinorW
Copy link
Collaborator

@ElinorW ElinorW commented Nov 26, 2024

Overview

Update request body, request header, modify permissions and access token tabs

Demo

image
image
image

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output

@ElinorW ElinorW changed the base branch from feat/add-fluent-v9 to feat/fluent-v9-upgrade November 26, 2024 11:28
@ElinorW ElinorW marked this pull request as ready for review November 28, 2024 11:13
@ElinorW ElinorW requested a review from a team as a code owner November 28, 2024 11:13
});

export function Auth() {
const { auth: { authToken }, profile, dimensions: {request:{height}}} = useAppSelector((state) => state);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use state values individually

});

const RequestHeaders = () => {
const { sampleQuery, dimensions: { request: { height } } } = useAppSelector((state) => state);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get state variables individually.

@musale
Copy link
Contributor

musale commented Nov 28, 2024

This is coming along well! I tested locally and everything looks great, really good stuff. I experienced a slight issue with resizing though. In some cases, I can resize up/down and when I release, I can't resize again. In other cases, I could not trigger a resize. See this:

resizing-request-region.mp4

@ElinorW
Copy link
Collaborator Author

ElinorW commented Nov 29, 2024

This is coming along well! I tested locally and everything looks great, really good stuff. I experienced a slight issue with resizing though. In some cases, I can resize up/down and when I release, I can't resize again. In other cases, I could not trigger a resize. See this:

resizing-request-region.mp4

Ahh this is a nice catch, I'm going to test the resizing some more and fix the issue.



interface IRequestProps {
handleOnEditorChange: ()=> void
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
handleOnEditorChange: ()=> void
handleOnEditorChange: () => void

Copy link

sonarcloud bot commented Dec 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
6.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3441.centralus.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants