Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a notification banner to display for first time users #3396

Open
wants to merge 24 commits into
base: dev
Choose a base branch
from
Open

feat: add a notification banner to display for first time users #3396

wants to merge 24 commits into from
+1,849 −113

Conversation

musale
Copy link
Contributor

@musale musale commented Oct 29, 2024 •
edited
Loading

Closes #3385

Notes:

  • Telemetry has been implemented partially as more information on flighting is being sought.
  • Components used are fluent UI v9 as we're migrating to them.

@musale
WIP: set basics for the Notification banner
2a7a2e3
@musale
Revert to previous functionality
bd5a321
@musale
Use v8 styling construct and a MessageBar
f26b351
@musale
Merge branch 'dev' into feat/notification-banner
fb0096e
@musale
Use fluent v9 and get messages for notification from GE.json
377f689
@musale
Add fluent v9 components dependencies
06c88b3
@musale
Update styles and components for Notification
daf6010
@musale
Add text for notification
31949f8
@musale
Hook theming of v9 provider to prop value
bda0a91
@musale
Track the tutorial link with telemetry
e248e4a
@musale
Add slice banner
2ef65a5
@musale
Persist banner state to localstorage
39814b6
@musale
Update state usage of banner state
24fa979
@musale
Use local storage to track banner visibility
1d80997
@musale
Add the background and custom types
0ec9823
@musale
Fix theming and sizing of text in the body
f630d65
@musale
Handle dismissing of the banner
8891992
@musale musale marked this pull request as ready for review November 6, 2024 09:18
@musale musale requested a review from a team as a code owner November 6, 2024 09:18
musale
musale commented Nov 6, 2024
View reviewed changes
src/messages/GE.json Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
12.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3396.centralus.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicaaawu jessicaaawu jessicaaawu left review comments

@ElinorW ElinorW ElinorW left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GE Banner linking to tutorial for first time users
3 participants
@musale @ElinorW @jessicaaawu