Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aad-advanced-queries.md #9468

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Spucelik
Copy link

Added clarification when using dynamic and native field types.

Important

Required for API changes:

  • Link to API.md file: ADD LINK HERE
  • Link to PR for public-facing schema changes (schema-Prod-beta/v1.0.csdl): ADD LINK HERE

Add other supporting information, such as a description of the PR changes:

ADD INFORMATION HERE


Important

The following guidance is for Microsoft employees only. Community contributors can ignore this message; our content team will manage the status.

After you've created your PR, expand this section for tips and additional instructions.
  • do not merge is the default PR status and is automatically added to all open PRs that don't have the ready to merge label.
  • Add the ready for content review label to start a review. Only PRs that have met the minimum requirements for content review and have this label are reviewed.
  • If your content reviewer requests changes, review the feedback and address accordingly as soon as possible to keep your pull request moving forward. After you address the feedback, remove the changes requested label, add the review feedback addressed label, and select the Re-request review icon next to the content reviewer's alias. If you can't add labels, add a comment with #feedback-addressed to the pull request.
  • After the content review is complete, your reviewer will add the content review complete label. When the updates in this PR are ready for external customers to use, replace the do not merge label with ready to merge and the PR will be merged within 24 working hours.
  • Pull requests that are inactive for more than 6 weeks will be automatically closed. Before that, you receive reminders at 2 weeks, 4 weeks, and 6 weeks. If you still need the PR, you can reopen or recreate the request.

For more information, see the Content review process summary.

Added clarification when using dynamic and native field types.
Copy link

Learn Build status updates of commit a22cad6:

✅ Validation status: passed

File Status Preview URL Details
concepts/aad-advanced-queries.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@@ -152,6 +152,7 @@ The following table lists query scenarios on directory objects that are supporte
> + `$expand` is not currently supported with advanced queries.
> + The advanced query capabilities are currently not available for Azure AD B2C tenants.
> + To use advanced query capabilities in [batch requests](json-batching.md), specify the **ConsistencyLevel** header in the JSON body of the `POST` request.
> + Using a mix of native and dynamic files is not supported. For example: /drives/{{ContainerID}}/items?$filter=listitem/fields/{{columnName}} eq '{{ColumnValue}}' AND name eq '{{DocumentName}}' should be formatted as: /drives/{{ContainerID}}/items?$filter=listitem/fields/{{columnName}} eq '{{ColumnValue}}' AND listitem/fields/FileLeafRef eq '{{DocumentName}}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This article is specific to Microsoft Entra, but you are adding details about a specific relationship on drive resources. There currently is no page for the items relationship on drive so that will first need to be created and then this information should go in there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or I don't really know if relationships get their own docs page. We should figure out how to document this, but a Microsoft Entra page is not the right place.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be that we just need to give a consistent behaviour for all driveItem collections (so OData support should probably be consistent on GET drive/items, drive/special, drive/following, drive/bundles, driveItem/children, etc.

@@ -152,6 +152,7 @@ The following table lists query scenarios on directory objects that are supporte
> + `$expand` is not currently supported with advanced queries.
> + The advanced query capabilities are currently not available for Azure AD B2C tenants.
> + To use advanced query capabilities in [batch requests](json-batching.md), specify the **ConsistencyLevel** header in the JSON body of the `POST` request.
> + Using a mix of native and dynamic files is not supported. For example: /drives/{{ContainerID}}/items?$filter=listitem/fields/{{columnName}} eq '{{ColumnValue}}' AND name eq '{{DocumentName}}' should be formatted as: /drives/{{ContainerID}}/items?$filter=listitem/fields/{{columnName}} eq '{{ColumnValue}}' AND listitem/fields/FileLeafRef eq '{{DocumentName}}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per Diego's comment, this is not the right topic for this information. Would it make sense to add it to the overview topic for the Files node? https://learn.microsoft.com/en-us/graph/api/resources/onedrive?view=graph-rest-1.0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dluces considering that this functionality is specific to drive items, I suggest we expand the get driveItem to include standard filter functionality. We should also include the limitations were seeing on children on the List children page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Spucelik the "get driveItem" page is to get a single driveItem (so when you have a driveItem id). There's no pagination or filtering when you get a single object. We just don't have a page yet to get driveItems within a drive which is what this applies to.

By the way, the "List children" page has a completely different set of limitations than the "drive.items" one.

@Lauragra Lauragra self-assigned this Nov 23, 2024
@Lauragra Lauragra added content review in progress changes requested do not merge Use this label to indicate to the repository admins that your PR Is not ready to merge into master. labels Nov 23, 2024
Copy link
Contributor

@Spucelik, your content reviewer has requested changes to your pull request. Please review feedback and address accordingly as soon as possible to keep your pull request moving forward.

Once you have addressed the feedback, please add the review feedback addressed label and select the Re-request review icon next to the content reviewer's alias.

If you cannot add labels, please add a comment with #feedback-addressed to the pull request.

Check the content review workflow here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested content review in progress do not merge Use this label to indicate to the repository admins that your PR Is not ready to merge into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants