Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Graph rule ID associated with activation role setting #2 (identity-governance-pim-rules-overview.md) #9381

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ashtmMSFT
Copy link

In the "Activation rules" section, the setting marked as #2 seems to be mapped to the incorrect rule. Instead of "Enablement_Admin_Eligibility", it should be "Enablement_EndUser_Assignment". The 'Enforced for caller' column should likely also be updated to 'End User'.

This is further supported by a separate Learn page which shows how to correctly call this API: https://learn.microsoft.com/en-us/graph/how-to-pim-update-rules?tabs=http#example-2-update-the-justification-mfa-and-ticketing-rules-required-on-activation

For more context/repros, please see my Q&A post here: https://learn.microsoft.com/en-us/answers/questions/1656721/pim-activation-settings-for-an-entra-role-exposed

Instructions: Add any supporting information, such as a description of the PR changes, here.


Note

The following guidance is for Microsoft employees only. Community contributors can ignore this message; our content team will manage the status.

After you've created your PR, expand this section for tips and additional instructions.
  • do not merge is the default PR status and is automatically added to all open PRs that don't have the ready to merge label.
  • Add the ready for content review label to start a review. Your PR won't be reviewed until you add this label.
  • If your content reviewer requests changes, review the feedback and address accordingly as soon as possible to keep your pull request moving forward. After you address the feedback, remove the changes requested label, add the review feedback addressed label, and select the Re-request review icon next to the content reviewer's alias. If you can't add labels, add a comment with #feedback-addressed to the pull request.
  • After the content review is complete, your reviewer will add the content review complete label. When the updates in this PR are ready for external customers to use, replace the do not merge label with ready to merge and the PR will be merged within 24 working hours.
  • Pull requests that are inactive for more than 6 weeks will be automatically closed. Before that, you receive reminders at 2 weeks, 4 weeks, and 6 weeks. If you still need the PR, you can reopen or recreate the request.

For more information, see the Content review process summary.

In the "Activation rules" section, the setting marked as #2 seems to be mapped to the incorrect rule. Instead of "Enablement_Admin_Eligibility", it should be "Enablement_EndUser_Assignment". The 'Enforced for caller' column should likely also be updated to 'End User'.

This is further supported by a separate Learn page which shows how to correctly call this API: https://learn.microsoft.com/en-us/graph/how-to-pim-update-rules?tabs=http#example-2-update-the-justification-mfa-and-ticketing-rules-required-on-activation

For more context/repros, please see my confusion (and seeming resolution) on my Q&A post here:
https://learn.microsoft.com/en-us/answers/questions/1656721/pim-activation-settings-for-an-entra-role-exposed
Copy link

Learn Build status updates of commit 46be493:

✅ Validation status: passed

File Status Preview URL Details
concepts/identity-governance-pim-rules-overview.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Lauragra Lauragra added the review requested Use for external PRs that need to be reviewed by content author. label Jul 3, 2024
@FaithOmbongi FaithOmbongi self-assigned this Jul 3, 2024
@FaithOmbongi FaithOmbongi added area: Entra APIs and issues relating to Microsoft Entra (previously Azure AD) features. area: governance Issues relating to Governance APIs awaiting internal response content review in progress and removed review requested Use for external PRs that need to be reviewed by content author. labels Jul 3, 2024
Copy link

This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Entra APIs and issues relating to Microsoft Entra (previously Azure AD) features. area: governance Issues relating to Governance APIs awaiting internal response conflicting content review in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants