Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for terminal suggest widget, fix some bugs #234445

Merged
merged 18 commits into from
Nov 24, 2024
Merged

add tests for terminal suggest widget, fix some bugs #234445

merged 18 commits into from
Nov 24, 2024

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Nov 22, 2024 •
edited
Loading

Screenshot 2024-11-22 at 11 09 26 PM

@meganrogge meganrogge self-assigned this Nov 22, 2024
@meganrogge meganrogge added this to the November 2024 milestone Nov 22, 2024
@meganrogge meganrogge enabled auto-merge (squash) November 22, 2024 19:27
@meganrogge
Copy link
Contributor Author

Actually wip realized something

@meganrogge meganrogge marked this pull request as draft November 22, 2024 22:30
Tyriar
Tyriar requested changes Nov 22, 2024
View reviewed changes
extensions/terminal-suggest/src/terminalSuggestMain.test.ts Outdated Show resolved Hide resolved
extensions/terminal-suggest/src/terminalSuggestMain.test.ts Outdated Show resolved Hide resolved
extensions/terminal-suggest/src/terminalSuggestMain.test.ts Outdated Show resolved Hide resolved
scripts/test-integration.sh Outdated Show resolved Hide resolved
extensions/terminal-suggest/src/terminalSuggestMain.test.ts Outdated Show resolved Hide resolved
extensions/terminal-suggest/src/terminalSuggestMain.test.ts Outdated Show resolved Hide resolved
@meganrogge meganrogge marked this pull request as ready for review November 23, 2024 03:12
@meganrogge meganrogge changed the title add initial tests for suggest widget add initial tests for suggest widget, fix some bugs Nov 23, 2024
@meganrogge meganrogge changed the title add initial tests for suggest widget, fix some bugs add tests for terminal suggest widget, fix some bugs Nov 23, 2024
@meganrogge meganrogge merged commit 8eb7fac into main Nov 24, 2024
8 checks passed
@meganrogge meganrogge deleted the merogge/suggest-w-tests branch November 24, 2024 15:38
@meganrogge
Copy link
Contributor Author

I will address your follow-ups in another PR.

osortega pushed a commit that referenced this pull request Nov 26, 2024
@meganrogge @osortega
add tests for terminal suggest widget, fix some bugs (#234445)
f72a0a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
November 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@meganrogge @Tyriar