Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pasting code block in chat #234301

Merged
merged 32 commits into from
Nov 26, 2024
Merged

pasting code block in chat #234301

merged 32 commits into from
Nov 26, 2024

Conversation

justschen
Copy link
Contributor

@justschen justschen commented Nov 20, 2024

fix from #233358 (which was reverted)

previously approved + added a new fix for the text model

cc. @jrieken

@justschen justschen marked this pull request as ready for review November 25, 2024 17:11
@justschen justschen enabled auto-merge (squash) November 25, 2024 17:12
@vs-code-engineering vs-code-engineering bot added this to the November 2024 milestone Nov 25, 2024
mjbvz
mjbvz previously approved these changes Nov 25, 2024
Copy link
Member

@lszomoru lszomoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR build is failing

@justschen
Copy link
Contributor Author

hmm was green right before i updated the branch, let me investigate

…ntribution.ts` doesn't pollute editors with things that don't get disposed
@justschen justschen merged commit 6ff5e04 into microsoft:main Nov 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants