-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vsg] Update the glslang minimum required version to 15 #42294
Conversation
…on of glslang in vcpkg (15.0.0) to prevent vsg from building without glsl compiler support and causing a runtime error
Style suggestions accepted Co-authored-by: Kai Pastor <[email protected]>
Can you remove the version check in the build entirely rather than hardcoding a particular version from a different port? |
|
My understanding is that the package maintainer plans to address this in the next release, so I would prefer to defer to them. |
ATM this PR will break the build for users which explicitly select glslang 14 to avoid the problem which the PR wants to fix. |
Does that mean we should close this? I think we should either do what we normally do for version-constraints-in-build-systems, that is, patch them out entirely, or do what upstream wants to do. Replacing one hardcoded value with another isn't obviously an improvement to me, particularly if
|
I am going to test your suggestion and if it works I will update the PR |
PR build passed, did it work for you? |
Yes it worked! |
Sounds good, thanks! |
Updates the glslang minimum required version to the latest version of glslang in vcpkg (15.0.0).
Implemented by passing in an option to vcpkg_cmake_configure().
Failing to do so will prevent vsg from building with glsl compiler support, and will result in a runtime error.
Further information can be found here:
vsg-dev/VulkanSceneGraph#1326
SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.