Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement --config for specifying testconfig.json file #4124

Merged
merged 10 commits into from
Nov 25, 2024
Merged

Implement --config for specifying testconfig.json file #4124

merged 10 commits into from
Nov 25, 2024

Conversation

Youssef1313
Copy link
Member

Fixes #3562

@microsoft-github-policy-service microsoft-github-policy-service bot added Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library Type: Feature labels Nov 22, 2024
@Youssef1313 Youssef1313 marked this pull request as draft November 22, 2024 11:55
Evangelink
Evangelink reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good ❤️ :shipit:

@MarcoRossignoli please also review

@Youssef1313 Youssef1313 marked this pull request as ready for review November 25, 2024 08:52
MarcoRossignoli
MarcoRossignoli reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good, I would add the validation and remove the usage of the GetFullPath api.

@Evangelink Evangelink merged commit e3900ac into microsoft:main Nov 25, 2024
6 checks passed
@Youssef1313 Youssef1313 deleted the config-commandline branch November 25, 2024 15:10
@Evangelink Evangelink mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink left review comments

@MarcoRossignoli MarcoRossignoli Awaiting requested review from MarcoRossignoli MarcoRossignoli is a code owner

Assignees
No one assigned
Labels
Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for --config <path-to-testconfig.json> file
3 participants
@Youssef1313 @MarcoRossignoli @Evangelink