Feature: Add JFrog V2 Service Endpoint Data Source (Issue #1231) #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
xuzhang3
requested changes
Dec 16, 2024
There was a problem hiding this comment.
@jasonouellet Except for the properties used to retrieve resource, other properties should marked with compute=true in the scheme. You can take data_serviceendpoint_azurecr example. I only commented data_serviceendpoint_jfrog_artifactory_v2.go, all the resources needs to be updated.
Once those are fixed up I can take another look.
azuredevops/internal/service/serviceendpoint/data_serviceendpoint_jfrog_artifactory_v2.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/data_serviceendpoint_jfrog_artifactory_v2.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/data_serviceendpoint_jfrog_artifactory_v2.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/data_serviceendpoint_jfrog_artifactory_v2.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/data_serviceendpoint_jfrog_artifactory_v2.go
Outdated
Show resolved
Hide resolved
xuzhang3
requested changes
Dec 23, 2024
Comment on lines
+25
to
+43
| "url": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| ValidateFunc: validate.Url, | ||
| Computed: true, | ||
| Optional: true, | ||
| MinItems: 1, | ||
| MaxItems: 1, | ||
| Elem: &schema.Resource{ | ||
| Schema: map[string]*schema.Schema{ | ||
| "token": { | ||
| Description: "The JFrog Artifactory access token.", | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| Sensitive: true, | ||
| }, | ||
| }, | ||
| }, | ||
| ExactlyOneOf: []string{"authentication_basic", "authentication_token"}, |
There was a problem hiding this comment.
Suggested change
| "url": { | |
| Type: schema.TypeString, | |
| Required: true, | |
| ValidateFunc: validate.Url, | |
| Computed: true, | |
| Optional: true, | |
| MinItems: 1, | |
| MaxItems: 1, | |
| Elem: &schema.Resource{ | |
| Schema: map[string]*schema.Schema{ | |
| "token": { | |
| Description: "The JFrog Artifactory access token.", | |
| Type: schema.TypeString, | |
| Required: true, | |
| Sensitive: true, | |
| }, | |
| }, | |
| }, | |
| ExactlyOneOf: []string{"authentication_basic", "authentication_token"}, | |
| "url": { | |
| Type: schema.TypeString, | |
| Computed: true, | |
| }, |
Comment on lines
+24
to
+30
| "url": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| ValidateFunc: validate.Url, | ||
| Description: "Url for the JFrog Artifactory Server", | ||
| Computed: true, | ||
| }, |
There was a problem hiding this comment.
Suggested change
| "url": { | |
| Type: schema.TypeString, | |
| Required: true, | |
| ValidateFunc: validate.Url, | |
| Description: "Url for the JFrog Artifactory Server", | |
| Computed: true, | |
| }, | |
| "url": { | |
| Type: schema.TypeString, | |
| Computed: true, | |
| }, |
Comment on lines
+25
to
+31
| "url": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| ValidateFunc: validate.Url, | ||
| Description: "Url for the JFrog Artifactory Server", | ||
| Computed: true, | ||
| }, |
There was a problem hiding this comment.
Suggested change
| "url": { | |
| Type: schema.TypeString, | |
| Required: true, | |
| ValidateFunc: validate.Url, | |
| Description: "Url for the JFrog Artifactory Server", | |
| Computed: true, | |
| }, | |
| "url": { | |
| Type: schema.TypeString, | |
| Computed: true, | |
| }, |
Comment on lines
+25
to
+31
| "url": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| ValidateFunc: validate.Url, | ||
| Description: "Url for the JFrog Artifactory Server", | ||
| Computed: true, | ||
| }, |
There was a problem hiding this comment.
Suggested change
| "url": { | |
| Type: schema.TypeString, | |
| Required: true, | |
| ValidateFunc: validate.Url, | |
| Description: "Url for the JFrog Artifactory Server", | |
| Computed: true, | |
| }, | |
| "url": { | |
| Type: schema.TypeString, | |
| Computed: true, | |
| }, |
| if err = checkServiceConnection(serviceEndpoint); err != nil { | ||
| return err | ||
| } | ||
| flattenServiceEndpointArtifactoryV2(d, serviceEndpoint) |
There was a problem hiding this comment.
Suggested change
| flattenServiceEndpointArtifactoryV2(d, serviceEndpoint) | |
| d.Set("url", serviceEndpoint.Url) |
| if err = checkServiceConnection(serviceEndpoint); err != nil { | ||
| return err | ||
| } | ||
| flattenServiceEndpointArtifactoryV2(d, serviceEndpoint) |
There was a problem hiding this comment.
Suggested change
| flattenServiceEndpointArtifactoryV2(d, serviceEndpoint) | |
| d.Set("url", serviceEndpoint.Url) |
|
|
||
| In addition to the Arguments list above - the following Attributes are exported: | ||
|
|
||
| * `authorization` - Specifies the Authorization Scheme Map. |
There was a problem hiding this comment.
Suggested change
| * `authorization` - Specifies the Authorization Scheme Map. | |
| * `url` - The URL of the Artifactory server to connect with. |
|
|
||
| In addition to the Arguments list above - the following Attributes are exported: | ||
|
|
||
| * `authorization` - Specifies the Authorization Scheme Map. |
There was a problem hiding this comment.
Suggested change
| * `authorization` - Specifies the Authorization Scheme Map. | |
| * `url` - The URL of the Artifactory server to connect with. |
|
|
||
| In addition to the Arguments list above - the following Attributes are exported: | ||
|
|
||
| * `authorization` - Specifies the Authorization Scheme Map. |
There was a problem hiding this comment.
Suggested change
| * `authorization` - Specifies the Authorization Scheme Map. | |
| * `url` - The URL of the Artifactory server to connect with. |
|
|
||
| In addition to the Arguments list above - the following Attributes are exported: | ||
|
|
||
| * `authorization` - Specifies the Authorization Scheme Map. |
There was a problem hiding this comment.
Suggested change
| * `authorization` - Specifies the Authorization Scheme Map. | |
| * `url` - The URL of the Artifactory server to connect with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
What about the current behavior has changed?
Issue Number: #1231
Ading data source:
Does this introduce a change to
go.mod,go.sumorvendor/?Does this introduce a breaking change?
Any relevant logs, error output, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Other information