Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log error code from hermes.dll load failure #14236

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Log error code from hermes.dll load failure #14236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
04de4d1
First attempt at logging DLL load failure info
danielayala94 Jan 2, 2025
51ce815
Change files
danielayala94 Jan 3, 2025
4e4044e
Merge branch 'main' into logDllLoadError
danielayala94 Jan 4, 2025
b31462f
Fixed format
danielayala94 Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-26f2e365-fe3c-4635-8874-2e9536724017.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "First attempt at logging DLL load failure info",
"packageName": "react-native-windows",
"email": "[email protected]",
"dependentChangeType": "none"
}
9 changes: 8 additions & 1 deletion vnext/Shared/HermesRuntimeHolder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,14 @@ void NAPI_CDECL removeInspectorPage(int32_t pageId) noexcept;

class HermesFuncResolver : public IFuncResolver {
public:
HermesFuncResolver() : libHandle_(LoadLibraryAsPeerFirst(L"hermes.dll")) {}
HermesFuncResolver() {
libHandle_ = LoadLibraryAsPeerFirst(L"hermes.dll");

// If hermes.dll failed to load, catch the last Win32 error and surface it.
if (libHandle_ == nullptr) {
CRASH_ON_ERROR(GetLastError());
}
}

FuncPtr getFuncPtr(const char *funcName) override {
return reinterpret_cast<FuncPtr>(GetProcAddress(libHandle_, funcName));
Expand Down