Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Downgrade to Xcode 15, don't run pod install with react-native-macos-init #2271

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Nov 12, 2024

Two changes:

Downgrade to Xcode 15

Reverts #2207

Changes in ADO's images means we don't have Xcode 16 on macOS 14, and macOS 15 isn't guaranteed to have visionOS. So we're stuck until we move to GitHub Actions or we get an Arm64 only image of macOS 15.

Don't run pod install with react-native-macos-init

This caused a failure in CI, and we probably shouldn't do this anyway.

@Saadnajmi Saadnajmi requested a review from a team as a code owner November 12, 2024 18:28
Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add an issue for migrating to GHA and/or upgrading to Xcode 16?

@Saadnajmi
Copy link
Collaborator Author

Can you also add an issue for migrating to GHA and/or upgrading to Xcode 16?

#2272 and #2273

@Saadnajmi Saadnajmi changed the title Revert "chore(ci): Update to Xcode 16" ci: Downgrade to Xcode 15, don't run pod install with react-native-macos-init Nov 12, 2024
@Saadnajmi Saadnajmi enabled auto-merge (squash) November 13, 2024 01:45
@Saadnajmi Saadnajmi merged commit ffd6abb into main Nov 13, 2024
14 checks passed
@Saadnajmi Saadnajmi deleted the revert-2207-update-apple branch November 14, 2024 01:22
Saadnajmi added a commit to Saadnajmi/react-native-macos that referenced this pull request Nov 14, 2024
…-macos-init` (microsoft#2271)

* Revert "chore(ci): Update to Xcode 16 (microsoft#2207)"

This reverts commit 9bf6051.

* Update generate-macos.js

* Update index.js

* Update test-react-native-macos-init.yml

* Update index.js
Saadnajmi added a commit that referenced this pull request Nov 14, 2024
…-macos-init` (#2271)

* Revert "chore(ci): Update to Xcode 16 (#2207)"

This reverts commit 9bf6051.

* Update generate-macos.js

* Update index.js

* Update test-react-native-macos-init.yml

* Update index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants