ci: fix the react-native-macos-init pipeline
#2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tido64
commented
Oct 21, 2024
|
Probably worth renaming the job to "Verify React Native macOS CLI" or something of that sort since it no longer just tests |
tido64
force-pushed
the
tido/test-build-macos
branch
23 times, most recently
from
183d6ce
to
4963c68
Compare
tido64
changed the title
build-macos to cireact-native-macos-init pipeline
tido64
commented
Oct 23, 2024
The pipeline wasn't actually publishing anything and we've been testing against latest on npm all this time.
tido64
force-pushed
the
tido/test-build-macos
branch
from
cd890bb
to
3e98753
Compare
|
Build currently fails probably due to missing facebook@774fe0c |
Spoke offline, I'll merge as is and then rebase #2190 which should fix the pipeline. |
Saadnajmi
approved these changes
Oct 24, 2024
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Nov 13, 2024
* ci: fix the `react-native-macos-init` pipeline The pipeline wasn't actually publishing anything and we've been testing against latest on npm all this time. * fix(react-native): `xcodeProject.path` may not always be present
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Nov 14, 2024
* ci: fix the `react-native-macos-init` pipeline The pipeline wasn't actually publishing anything and we've been testing against latest on npm all this time. * fix(react-native): `xcodeProject.path` may not always be present
Saadnajmi
pushed a commit
that referenced
this pull request
Nov 14, 2024
* ci: fix the `react-native-macos-init` pipeline The pipeline wasn't actually publishing anything and we've been testing against latest on npm all this time. * fix(react-native): `xcodeProject.path` may not always be present
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Nov 14, 2024
* ci: fix the `react-native-macos-init` pipeline The pipeline wasn't actually publishing anything and we've been testing against latest on npm all this time. * fix(react-native): `xcodeProject.path` may not always be present
Saadnajmi
pushed a commit
that referenced
this pull request
Nov 14, 2024
* ci: fix the `react-native-macos-init` pipeline The pipeline wasn't actually publishing anything and we've been testing against latest on npm all this time. * fix(react-native): `xcodeProject.path` may not always be present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The pipeline wasn't actually publishing anything and we've been testing against latest on npm all this time.
Test Plan:
CI should pass.