docs: add explainer for gotchas with NSView based native components #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as draft to see if I can update RCTUIView hitTest instead |
tido64
reviewed
Nov 14, 2024
Co-authored-by: Tommy Nguyen <[email protected]>
tido64
approved these changes
Nov 14, 2024
Saadnajmi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
While working on microsoft/fluentui-react-native#3026, I found a couple of "gotchas" while writing a native component for
NSVisualEffectView. This change attempts to documents those gotchas so that others can benefit. Special thanks to @lenaic who figured out the hit testing issue.Changelog
[GENERAL] [ADDED] - Add documentation for gotchas with NSView based native components
Test Plan
N/A