Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricting spacy.cli for version 3.7.0 #1495

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Conversation

kshitijcode
Copy link
Contributor

@kshitijcode kshitijcode commented Dec 10, 2024

Change Description

Describe your changes

Puts restriction on installing spacy 3.7.0

Issue reference

This PR fixes issue #1487

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@kshitijcode kshitijcode requested a review from a team as a code owner December 10, 2024 08:57
@kshitijcode kshitijcode changed the title Update pyproject.toml Restricting spacy.cli for version 3.7.0 Dec 10, 2024
@omri374
Copy link
Contributor

omri374 commented Dec 10, 2024

Thanks! Do you think it would be possible to do this for the presidio-analyzer module? This way it would avoid this pitfall for other use cases as well, not just for CLI users

@kshitijcode
Copy link
Contributor Author

@omri374 added it to the presidio-analyzer module as well.

@SharonHart
Copy link
Contributor

Isn't defining it in the upper-most pyptoject.toml making it apply to all modules?

@omri374
Copy link
Contributor

omri374 commented Dec 11, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374
Copy link
Contributor

omri374 commented Dec 11, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374 omri374 merged commit ebf0ca5 into microsoft:main Dec 11, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants