Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added py.typed file and modified the setup.py files #1201

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

Ashhar-24
Copy link
Contributor

Change Description

As the issue #905 wanted to add missing py.typed in published packages in order to support mypy/pyright type checking, I've added py.typed files in all the three libraries presidio-analyzer , presidio-anonymizer and presidio-image-redactor.

Issue reference

This PR fixes issue #905

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@Ashhar-24
Copy link
Contributor Author

@microsoft-github-policy-service agree

@omri374
Copy link
Contributor

omri374 commented Oct 31, 2023

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Ashhar-24
Copy link
Contributor Author

Do I need to make any changes @omri374 in the code?

@omri374
Copy link
Contributor

omri374 commented Nov 1, 2023

Hi @Ashhar-24, thanks for this! I don't think so, but we'll check internally. I ran mypy after this change and there are a few issues that it raised. We'll discuss it internally and get back to you. The CI is failing due to a different problem, sorry about that.

@Ashhar-24
Copy link
Contributor Author

Ashhar-24 commented Nov 1, 2023

oh, okay.
Do let know if there's any changed required in the code, I'll be happy to work on it.

@Ashhar-24
Copy link
Contributor Author

@omri374 can you please add a hacktoberfest-accepted label so that this PR gets counted as a successful-PR for me in the hacktoberfest programm.

@Ashhar-24
Copy link
Contributor Author

@omri374 one last thing, how much time will it take to get this PR merged, like in order to merge this PR requires At least 2 approving reviews .

@omri374 omri374 merged commit ac56089 into microsoft:main Nov 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants