Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dockerfile for Windows containers #1194

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Add Dockerfile for Windows containers #1194

merged 4 commits into from
Nov 15, 2023

Conversation

TheIndra55
Copy link
Contributor

@TheIndra55 TheIndra55 commented Oct 25, 2023 •
edited
Loading

Change Description

Adds a Dockerfile for building the containers for Windows containers.

Allows running the images natively on Windows. Tested the image build and run on Windows 11 22H2.

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@omri374
Copy link
Contributor

omri374 commented Oct 30, 2023

Thanks!

@omri374
Copy link
Contributor

omri374 commented Nov 8, 2023

Hi @TheIndra55, apologies for the late reviews. We'd like to test this, hence the delay.

@TheIndra55
Copy link
Contributor Author

No problem, we have our own fork. Please let me know you have any comments 🙂

@omri374 omri374 merged commit 8b9d961 into microsoft:main Nov 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharonHart SharonHart SharonHart approved these changes

@omri374 omri374 omri374 approved these changes

@navalev navalev Awaiting requested review from navalev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheIndra55 @omri374 @SharonHart