fix: throw when serializing FilePayload in Form Fetch request #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
campersau
reviewed
Aug 17, 2023
Co-authored-by: campersau <[email protected]>
yury-s
approved these changes
Aug 17, 2023
| { | ||
| var output = new List<object>(); | ||
| foreach (var kvp in Values) | ||
| { | ||
| if (kvp.Value is FilePayload file) | ||
| { | ||
| if (throwWhenSerializingFilePayloads) | ||
| { | ||
| throw new PlaywrightException("Form requests don't support file payloads, use Multipart=formData instead."); |
There was a problem hiding this comment.
Doesn't it serialize just file name in case of url encoded params? In java we just send it as a json object which should make it clear on the receiving end that something was wrong with the encoding.
There was a problem hiding this comment.
Java serializes to JSON:
in JS we are more strict:
form?: { [key: string]: string|number|boolean; };
multipart?: { [key: string]: string|number|boolean|fs.ReadStream|FilePayload; };
so we simply not allow it. See here:
In Python we probably throw protocol wise: https://github.com/microsoft/playwright-python/blob/42c0bf19d7ae415552172d7c04cdb7afd9dad7fb/playwright/_impl/_fetch.py#L343
mxschmitt
deleted the
fix-do-not-allow-serializing-files-in-form-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2662
This might affect Java as well.