fix(browserType): fix env property serialization (#1074)

closes #1072
microsoft · Dec 21, 2020 · 88a62f3 · 88a62f3
1 parent 5dfec1e
commit 88a62f3
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/PlaywrightSharp.Tests/BrowserTypeLaunchTests.cs b/src/PlaywrightSharp.Tests/BrowserTypeLaunchTests.cs
@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using System.IO;
 using System.Linq;
 using System.Threading.Tasks;
@@ -155,5 +156,20 @@ public async Task ShouldBeCallableTwice()
             await TaskUtils.WhenAll(browser.CloseAsync(), browser.CloseAsync());
             await browser.CloseAsync();
         }
+
+        /// <summary>
+        /// PuppeteerSharp test. It's not in upstream
+        /// </summary>
+        [Fact(Timeout = PlaywrightSharp.Playwright.DefaultTimeout)]
+        public async Task ShouldWorkWithEnvironmentVariables()
+        {
+            var options = TestConstants.GetDefaultBrowserOptions();
+            options.Env = new Dictionary<string, string>
+            {
+                ["Foo"] = "Var"
+            };
+
+            await using var browser = await BrowserType.LaunchAsync(options);
+        }
     }
 }
diff --git a/src/PlaywrightSharp/LaunchOptions.cs b/src/PlaywrightSharp/LaunchOptions.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
 
 namespace PlaywrightSharp
 {
@@ -195,7 +196,7 @@ internal virtual Dictionary<string, object> ToChannelDictionary()
 
             if (Env != null)
             {
-                args["env"] = Env;
+                args["env"] = Env.Select(kv => new NameValueEntry(kv.Key, kv.Value));
             }
 
             if (FirefoxUserPrefs != null)