Fix Video Hanging

src/Playwright.Tests/ScreencastTests.cs

@@ -171,4 +171,33 @@ public async Task ShouldCaptureStaticPageInPersistentContext()
 
         Assert.IsNotEmpty(new DirectoryInfo(tempDirectory.Path).GetFiles("*.webm"));
     }
+
+    [PlaywrightTest("screencast.spec.ts", "Video does not hang if page not interacted with")]
+    [Timeout(30_000)]
+    public async Task VideoDoesNotHangIfNotHeadlessAndPageNotInteractedWith()
+    {
+        using var tempDirectory = new TempDirectory();
+
+        var chrome = await Playwright.Chromium.LaunchAsync(new BrowserTypeLaunchOptions
+        {
+            Headless = false
+        });
+
+        var context = await chrome.NewContextAsync(new BrowserNewContextOptions
+        {
+            RecordVideoDir = tempDirectory.Path,
+        });
+
+        var page = await context.NewPageAsync();
+        await page.CloseAsync();
+
+        try
+        {
+            await page.Video!.PathAsync();
+        }
+        catch (TaskCanceledException)
+        {
+            // Ignored
+        }
+    }
 }

src/Playwright/Core/Page.cs

@@ -95,7 +95,13 @@ internal Page(IChannelOwner parent, string guid, PageInitializer initializer) :
 
             PageError?.Invoke(this, $"{e.Error.Name}: {e.Error.Message}");
         };
-        _channel.Video += (_, artifact) => ForceVideo().ArtifactReady(artifact);
+
+        _channel.Video += (_, artifact) => _video.ArtifactReady(artifact);
+
+        if (Context.Options.RecordVideoDir != null)
+        {
+            _video = new Video(this,  _channel.Connection);
+        }
 
         _channel.FileChooser += (_, e) => _fileChooserImpl?.Invoke(this, new FileChooser(this, e.Element.Object, e.IsMultiple));
         _channel.Worker += (_, worker) =>
@@ -237,15 +243,7 @@ public ITouchscreen Touchscreen
 
     public IVideo Video
     {
-        get
-        {
-            if (Context.Options.RecordVideoDir == null)
-            {
-                return null;
-            }
-
-            return ForceVideo();
-        }
+        get => _video;
         set => _video = value as Video;
     }
 
@@ -1276,8 +1274,6 @@ private Task InnerExposeBindingAsync(string name, Delegate callback, bool handle
         return _channel.ExposeBindingAsync(name, handle);
     }
 
-    private Video ForceVideo() => _video ??= new(this, _channel.Connection);
-
     private FrameSetInputFilesOptions Map(PageSetInputFilesOptions options)
     {
         if (options == null)