Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FetchPolicy in useLazyLoadQuery #97

Merged

Conversation

iukondra
Copy link
Contributor

No description provided.

| "store-or-network"
| "store-and-network"
| "network-only"
| "store-only";
| "store-only"
| "cache-first"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the new fetch policies? Are there from apollo-client? I think we should just use Relay ones as duct tape does translation. Right, @alloy ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apollo fetch policies. If we don't need to support them, I'm happy to remove them

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, only the Relay ones, and specifically the ones captured in the duct-tape transform 👍

Copy link
Contributor Author

@iukondra iukondra Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjwilczynski , @alloy I've removed Apollo fetch policies. I initially misunderstood what does duct tape do with them

Copy link
Contributor

@dragoshomner dragoshomner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please wait Eloy's review before completing it.

@iukondra iukondra requested review from alloy and sjwilczynski April 3, 2024 21:20
@alloy alloy merged commit f3910cc into microsoft:main Apr 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants