-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use FetchPolicy in useLazyLoadQuery #97
Use FetchPolicy in useLazyLoadQuery #97
Conversation
| "store-or-network" | ||
| "store-and-network" | ||
| "network-only" | ||
| "store-only"; | ||
| "store-only" | ||
| "cache-first" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the new fetch policies? Are there from apollo-client? I think we should just use Relay ones as duct tape does translation. Right, @alloy ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apollo fetch policies. If we don't need to support them, I'm happy to remove them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, only the Relay ones, and specifically the ones captured in the duct-tape transform 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sjwilczynski , @alloy I've removed Apollo fetch policies. I initially misunderstood what does duct tape do with them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Please wait Eloy's review before completing it.
No description provided.