Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump duct tape version for package deduplication and make compiler test work on windows #95

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Bump duct tape version for package deduplication and make compiler test work on windows #95

merged 5 commits into from
Mar 7, 2024

Conversation

sjwilczynski
Copy link
Contributor

There are two issues that this PR is trying to fix:

  • running tests for compiler fails on windows because spawnSync is not cross platform
  • repoes which depend on @nova/react-test-utils have to force version of duct tape as the current range is not deduplicatble with 1.x.

We fix both

@kerrynf kerrynf merged commit 13ff3c8 into microsoft:main Mar 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerrynf kerrynf kerrynf approved these changes

@Markionium Markionium Markionium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjwilczynski @Markionium @kerrynf