Allow fragment refs to be null or undefined #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjwilczynski
reviewed
Mar 7, 2024
| @@ -193,6 +252,39 @@ export function usePaginationFragment< | |||
| isLoadingNext: boolean; | |||
| isLoadingPrevious: boolean; | |||
| refetch: RefetchFn<TQuery["variables"]>; | |||
| }; | |||
| export function usePaginationFragment< | |||
There was a problem hiding this comment.
How is this definition different from one below?
There was a problem hiding this comment.
If you mean the one with the implementation then it isn't different. But afaik you can't have the implementation serve as one of the definitions.
There was a problem hiding this comment.
Aha, one is definition the other implementation
sjwilczynski
approved these changes
Mar 7, 2024
Markionium
force-pushed
the
make-fragment-ref-nullable
branch
from
96ddc10 to
960ca0b
Compare
alloy
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relay allows for fragment references to be
nullorundefined. Our typings have been stricter where they do not allownullorundefined.This causes us to miss out on things like
@skipand@include.This PR adds the ability to pass
nullorundefinedas the fragment reference touseFragmentusePaginationFragmentoruseRefetchableFragment.