Added optional source to GeneratedEventWrapper

[kennetvu]

We are currently integrating Jana into Outlook Web(OWA) and we need a way to catch a NovaEvent and then bubble it to parent provider if we dont want to deal with it. We are doing this by calling generateEvent(event), but with current generateEvent(event), source is generated on each call, which means we will lose metadata about source if it already exists in the event.

By adding a optional field source, we can generate only if source is not defined.

[sjwilczynski]

LGTM to me but let's add a test exactly for our use case

[kerrynf]

This change is a little weird, because we already support the timeStampOverride here, which is now completely ignored if the optional source is passed in.

[Markionium]

This kind of comes down to what we want the behaviour to be? :D

In this case it seems we just want to "forward" the event to a handler further up in the tree. In that case should the overrides apply as initially the event was likely created using bubble?

But perhaps we need another way to just "bubble" those events further? It's almost like just doing this?

forward: (eventWrapper: EventWrapper) => {
  return eventingRef.current.bubble(eventWrapper);
},

[kennetvu]

This change is a little weird, because we already support the timeStampOverride here, which is now completely ignored if the optional source is passed in.

We can also turn it around to check for timeStampOverride first, and then source. otherwise fallback to default which is {inputType: InputType.programmatic, timeStamp: Date.now()}

[kennetvu]

This kind of comes down to what we want the behaviour to be? :D

In this case it seems we just want to "forward" the event to a handler further up in the tree. In that case should the overrides apply as initially the event was likely created using bubble?

But perhaps we need another way to just "bubble" those events further? It's almost like just doing this?

forward: (eventWrapper: EventWrapper) => {
  return eventingRef.current.bubble(eventWrapper);
},

this is kind of what we wanted to achieve.

[sjwilczynski]

@kennetvu let's close this in favor of #93

[sjwilczynski]

Closing as intercepter pattern was implemented in #93