Add unmountEventing through the NovaEventingProvider #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewatk
changed the title
kerrynf
reviewed
Oct 6, 2023
kerrynf
reviewed
Oct 6, 2023
blakecscott
reviewed
Oct 9, 2023
blakecscott
approved these changes
Oct 9, 2023
blakecscott
approved these changes
Oct 9, 2023
kerrynf
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've discovered a need to have two versions of eventing at once during component unmounts. Useeffect cleanup functions need to use the old version of eventing to get the old context to ensure proper routing of events. This change will allow hosts to maintain two eventing references, with the unmount eventing switching out later to keep the reference to the old execution context before unmount.
This change adds a useNovaUnmountEventing hook in the nova eventing provider. It is supplied by a new
unmountEventingproperty. If the new property is not supplied, the new hook will use the existing eventing reference, to maintain backwards compatibility with nova hosts which do not need this functionality.