Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nova-react-test-utils): support Storybook 8 #129

Merged

Conversation

sjwilczynski
Copy link
Contributor

As reported some types used in the decorator are no longer available in v8, failing the build when using new version of Storybook in 1JS. In scope of this PR we:

  • replace ComposedStoryPlayContext with Partial<PlayFunctionContext> (we don't move to StoryContext yet as that is not containing info about play function in v7)
  • migrate examples to local dev to start using v8

@sjwilczynski sjwilczynski enabled auto-merge (squash) November 26, 2024 13:52
@sjwilczynski sjwilczynski merged commit 410fb36 into microsoft:main Nov 26, 2024
2 checks passed
@sjwilczynski sjwilczynski deleted the user/stwilczy/supportStorybook8 branch December 13, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants