fix(nova-react-test-utils): fix issue with store being shared between stories #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discovered when integrating new decorator in 1JS, there is a problem with passing relay environment config to the decorator. The issue is that when one used as in docs
getNovaDecorator(schema, { store: createStores() })that would cause a store to be shared between multiple stories ascreateStorefunction was executed once for the whole decorator. This means that we cannot just pass relay env options directly instead we change the code to pass function that gets the options.Tested using storybook and verifying each has unique data in store and results of resolvers don't not slip over. Theoretically it is a breaking change but as the option was not yet widely used, we mark it as minor.
Special thanks to @jakobkhansen for reporting and creating repro of the issue in https://github.com/jakobkhansen/nova-facade/tree/user/jakobhansen/sharedstore_repro