fix(nova-react-test-utils): adjust types to properly support pure Relay components #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 19, 2024 13:14
Markionium
approved these changes
Sep 19, 2024
| @@ -82,7 +83,11 @@ export function getRenderer( | |||
| ): React.FC<React.PropsWithChildren<unknown>> { | |||
| if (query) { | |||
| const Renderer: React.FC<unknown> = () => { | |||
| const { data } = useLazyLoadQuery(query, variables); | |||
| const { data } = useLazyLoadQuery( | |||
| // There are no consequences of the cast, we do it only to make sure pure relay components can also leverage the decorator | |||
There was a problem hiding this comment.
During runtime this would be replaced with the runtime document, so it's not actually even this type.
Which when using Nova and Relay should be the same document. But not sure if that is worth adding to the comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decorator is written in such a way that in can support pure Relay components, not only Nova. As it adds some features on top of Relay addon, making sure using it for pure Relay components can increase consistency and DX of working on Relay/Nova components. In scope of this PR we adjust decorator typing to support using without directly depending on
@nova/react.