Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nova-react-test-utils): throw error from apollo #112

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

sjwilczynski
Copy link
Contributor

While testing decorator integration in 1JS with apollo, I realized if there is some error inside the query for Story, it won't be propagated to the user in anyway, making it hard to debug. In Relay this is not an issue as Relay automatically throws. In scope of this PR, we:

  • throw error that Apollo might generate during query execution
  • make sure the behavior is aligned between Relay and Apollo in such case by adding a new Story which check it and unit test based on it
  • Showcase error behavior when ErrorBoundary is used
  • fix warning about dependencies duplicated between devDependencies and dependencies sections
  • fix comment in jest.config.ts in examples package

@sjwilczynski sjwilczynski enabled auto-merge (squash) September 19, 2024 09:27
@sjwilczynski sjwilczynski merged commit 9f8fe14 into microsoft:main Sep 19, 2024
2 checks passed
@sjwilczynski sjwilczynski deleted the stwilczy/errorScenario branch September 19, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants