Latest Generic is wrong (#3722)

Latest Generic is wrong when developing BcContainerHelper (i.e. LatestGenericVersion.txt contains 0.0.0.0) --------- Co-authored-by: freddydk <[email protected]>
microsoft · Oct 15, 2024 · abda51e · abda51e
1 parent 88b0849
commit abda51e
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/BcContainerHelper.psm1 b/BcContainerHelper.psm1
@@ -287,3 +287,12 @@ if ($isWindows) {
 . (Join-Path $PSScriptRoot "PackageHandling\Publish-BuildOutputToStorage.ps1")
 . (Join-Path $PSScriptRoot "PackageHandling\Get-AzureFeedWildcardVersion.ps1")
 . (Join-Path $PSScriptRoot "PackageHandling\Install-AzDevops.ps1")
+
+# In Development mode only
+if ($LatestGenericTagVersion -eq '0.0.0.0') {
+    $labels = Get-BcContainerImageLabels -imageName 'mcr.microsoft.com/businesscentral:ltsc2022'
+    if ($labels) {
+        $LatestGenericTagVersion = $labels.tag
+        Write-Host "LatestGenericTagVersion is $LatestGenericTagVersion"
+    }
+}
diff --git a/ContainerHandling/Get-BestGenericImageName.ps1 b/ContainerHandling/Get-BestGenericImageName.ps1
@@ -16,12 +16,6 @@ function Get-BestGenericImageName {
 $telemetryScope = InitTelemetryScope -name $MyInvocation.InvocationName -parameterValues $PSBoundParameters -includeParameters @()
 try {
 
-    if ($LatestGenericTagVersion -eq '0.0.0.0') {
-        $labels = Get-BcContainerImageLabels -imageName 'mcr.microsoft.com/businesscentral:ltsc2022'
-        Write-Host "Setting LatestGenericTagVersion to $($labels.tag)"
-        $LatestGenericTagVersion = $labels.tag
-    }
-
     if ($hostOsVersion -eq $null) {
         $os = (Get-CimInstance Win32_OperatingSystem)
         if ($os.OSType -ne 18 -or !$os.Version.StartsWith("10.0.")) {

diff --git a/ContainerHandling/New-NavContainer.ps1 b/ContainerHandling/New-NavContainer.ps1
@@ -722,7 +722,7 @@ try {
             if ($artifactUrl) {
                 $genericTagVersion = [Version](Get-BcContainerGenericTag -containerOrImageName $imageName)
                 if ($genericTagVersion -lt [Version]$LatestGenericTagVersion) {
-                    Write-Host "Generic image is version $genericTagVersion - pulling a newer image"
+                    Write-Host "Existing generic image is version $genericTagVersion - pulling a newer image"
                     $pullit = $true
                 }
             }

diff --git a/Saas/Download-BcEnvironmentInstalledExtensionToFolder.ps1 b/Saas/Download-BcEnvironmentInstalledExtensionToFolder.ps1
@@ -42,7 +42,7 @@ function Download-BcEnvironmentInstalledExtensionToFolder {
         [Parameter(Mandatory = $true)]
         [string] $appName,
         [Parameter(Mandatory = $true)]        
-        [string] $appVersion = '0.0.0.0',
+        [string] $appVersion,
         [Parameter(Mandatory = $false)]
         [string] $appId
     )