Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve version deployment documentation #4646

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

anrossi
Copy link
Contributor

@anrossi anrossi commented Nov 5, 2024

Description

Improve the version deployment documentation.

@anrossi anrossi requested a review from a team as a code owner November 5, 2024 02:10
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.79%. Comparing base (14810af) to head (3b4df79).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4646      +/-   ##
==========================================
- Coverage   87.22%   86.79%   -0.43%     
==========================================
  Files          56       56              
  Lines       17354    17354              
==========================================
- Hits        15137    15063      -74     
- Misses       2217     2291      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/Settings.md Show resolved Hide resolved
docs/Versions.md Outdated Show resolved Hide resolved
docs/Versions.md Outdated Show resolved Hide resolved
Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\MsQuic\Parameters]
"AcceptableVersions"=hex:cf,43,33,6b,01,00,00,00
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it doesn't work this way today, but I think it's worth updating the settings code (in a future PR) to handle a more simpler configuration model, where only one of these has to be implemented; including the Enabled one. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the risk of a single-list is that a deployment is made using the single-list model, and then we add QUIC 3 support, and the deployment either does the version rollout wrong, or the infrastructure isn't built to do the rollout, so they have to spend more time updating infrastructure and testing it to even do a rollout.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think that setting any version list via registry should enable the version negotiation extension without the extra registry value.

@nibanks nibanks merged commit 9587f74 into main Nov 6, 2024
479 of 481 checks passed
@nibanks nibanks deleted the anrossi/version-deployment-documentation branch November 6, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants