Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SecNetPerf Variables to be in Units of CPU Count #4588

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Oct 2, 2024

Description

Added the ability for secnetperf to use the unit of cpu to indicate it's a multiple of the number of CPUs on the machine. This is usefull for generically defining a perf test case that scales with the type of machine its run on.

Examples:

> secnetperf.exe -target:localhost -conns:1cpu -rstream:1 -plat:1 -up:100 -down:100 -run:1s
Started!

Result: 124985 RPS, Latency,us 0th: 37, 50th: 164, 90th: 414, 99th: 500, 99.9th: 557, 99.99th: 6013, 99.999th: 13355, 99.9999th: 13396, Max: 13396
App Main returning status 0


> secnetperf.exe -target:localhost -conns:2cpu -rstream:1 -plat:1 -up:100 -down:100 -run:1s
Started!

Result: 277589 RPS, Latency,us 0th: 47, 50th: 108, 90th: 352, 99th: 803, 99.9th: 1187, 99.99th: 10995, 99.999th: 20259, 99.9999th: 21174, Max: 21174
App Main returning status 0

Testing

Locally

Documentation

None atm

@nibanks nibanks requested a review from a team as a code owner October 2, 2024 16:28
@nibanks nibanks added Area: Testing Related to test coverage Area: Performance labels Oct 2, 2024
@csujedihy
Copy link
Contributor

2cpu = 2 connections per CPU?

@nibanks
Copy link
Member Author

nibanks commented Oct 2, 2024

2cpu = 2 connections per CPU?

Essentially. 2 * CPU count connections

@nibanks nibanks merged commit ecf88da into main Oct 2, 2024
476 of 478 checks passed
@nibanks nibanks deleted the cpu-perf-unit branch October 2, 2024 18:03
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.91%. Comparing base (eb76333) to head (c80907a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4588      +/-   ##
==========================================
- Coverage   87.04%   85.91%   -1.13%     
==========================================
  Files          56       56              
  Lines       17354    17354              
==========================================
- Hits        15106    14910     -196     
- Misses       2248     2444     +196     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Performance Area: Testing Related to test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants