Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alpine packaging and testing github action workflow #4554

Merged
merged 21 commits into from
Sep 27, 2024

Conversation

liveans
Copy link
Member

@liveans liveans commented Sep 22, 2024

Description

Add alpine packaging scripts with doc.

This PR adds two different main stuff:

  • APKBUILD (Alpine Packaging Script) creator script
  • Testing pipeline of packaging.

Testing

CI

Documentation

New doc added related to Alpine packaging steps.

@liveans liveans marked this pull request as ready for review September 26, 2024 15:35
@liveans liveans requested a review from a team as a code owner September 26, 2024 15:35
@liveans
Copy link
Member Author

liveans commented Sep 26, 2024

I marked this as ready for review, but I have another idea for PR packaging which will be almost same as production packaging. I'll give it a try.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.86%. Comparing base (ee4a1bc) to head (e42fbe1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4554      +/-   ##
==========================================
- Coverage   87.61%   86.86%   -0.75%     
==========================================
  Files          56       56              
  Lines       17354    17354              
==========================================
- Hits        15204    15074     -130     
- Misses       2150     2280     +130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liveans
Copy link
Member Author

liveans commented Sep 26, 2024

This is ready for review @nibanks

@liveans
Copy link
Member Author

liveans commented Sep 27, 2024

@nibanks If there is something you're not happy about in this PR, please let me know, I can fix it accordingly.

docs/PackagingAlpine.md Outdated Show resolved Hide resolved
docs/Release.md Outdated Show resolved Hide resolved
@@ -106,6 +106,20 @@ Sometimes the pipeline fails due to PMC infra issues (e.g. the PMC HTTP endpoint

When testing the pipeline, please make sure to comment out the PMC cli commands in [upload-linux-packages.sh](https://github.com/microsoft/msquic/blob/main/scripts/upload-linux-packages.sh) to avoid accidentally publishing packages into prod.

## Publishing MsQuic for Alpine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any practical hope to automate this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can have dedicated gitlab.alpinelinux.org account with an official microsoft email, I can automate this over gitlab APIs in Azure pipeline.

@nibanks nibanks enabled auto-merge (squash) September 27, 2024 13:16
@nibanks nibanks merged commit 56ef97b into microsoft:main Sep 27, 2024
469 checks passed
@liveans
Copy link
Member Author

liveans commented Sep 27, 2024

@nibanks Would you mind to backport this to release/2.4?

liveans added a commit to liveans/msquic that referenced this pull request Sep 27, 2024
@nibanks
Copy link
Member

nibanks commented Sep 27, 2024

@nibanks Would you mind to backport this to release/2.4?

If you create the PR, I will approve it. Do we need to create a new release for this though? I just kicked off the process for v2.4.5, and would prefer to not have to do it for just this.

@liveans
Copy link
Member Author

liveans commented Sep 27, 2024

@nibanks Would you mind to backport this to release/2.4?

If you create the PR, I will approve it. Do we need to create a new release for this though? I just kicked off the process for v2.4.5, and would prefer to not have to do it for just this.

We don't need a new release, I'll just copy script as a workaround for this release and create necessary APKBUILD file and update Alpine package on aports when packages are available on PMC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants