-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alpine packaging and testing github action workflow #4554
Conversation
I marked this as ready for review, but I have another idea for PR packaging which will be almost same as production packaging. I'll give it a try. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4554 +/- ##
==========================================
- Coverage 87.61% 86.86% -0.75%
==========================================
Files 56 56
Lines 17354 17354
==========================================
- Hits 15204 15074 -130
- Misses 2150 2280 +130 ☔ View full report in Codecov by Sentry. |
This is ready for review @nibanks |
@nibanks If there is something you're not happy about in this PR, please let me know, I can fix it accordingly. |
@@ -106,6 +106,20 @@ Sometimes the pipeline fails due to PMC infra issues (e.g. the PMC HTTP endpoint | |||
|
|||
When testing the pipeline, please make sure to comment out the PMC cli commands in [upload-linux-packages.sh](https://github.com/microsoft/msquic/blob/main/scripts/upload-linux-packages.sh) to avoid accidentally publishing packages into prod. | |||
|
|||
## Publishing MsQuic for Alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any practical hope to automate this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can have dedicated gitlab.alpinelinux.org
account with an official microsoft email, I can automate this over gitlab APIs in Azure pipeline.
@nibanks Would you mind to backport this to |
If you create the PR, I will approve it. Do we need to create a new release for this though? I just kicked off the process for v2.4.5, and would prefer to not have to do it for just this. |
We don't need a new release, I'll just copy script as a workaround for this release and create necessary APKBUILD file and update Alpine package on aports when packages are available on PMC. |
Description
Add alpine packaging scripts with doc.
This PR adds two different main stuff:
APKBUILD
(Alpine Packaging Script) creator scriptTesting
CI
Documentation
New doc added related to Alpine packaging steps.