Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to not set ideal proc on worker threads #4511

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

ThadHouse
Copy link
Contributor

Description

For resource reasons, I'm having to create a datapath with just a single threaded worker pool. I wouldn't want that thread affinitized to any specific thread. Add a flag to skip setting ideal proc on the worker thread.
 

Testing

Covered by existing tests

Documentation

Execution configs is currently an undocumented feature.

@ThadHouse ThadHouse requested a review from a team as a code owner August 29, 2024 03:57
@nibanks nibanks added the external Proposed by non-MSFT label Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.65%. Comparing base (c6e28b0) to head (06a47d0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4511      +/-   ##
==========================================
- Coverage   86.13%   85.65%   -0.49%     
==========================================
  Files          56       56              
  Lines       15521    15515       -6     
==========================================
- Hits        13369    13289      -80     
- Misses       2152     2226      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/inc/msquic.h Outdated Show resolved Hide resolved
@nibanks
Copy link
Member

nibanks commented Aug 29, 2024

.NET needs to be updated too please.

@nibanks nibanks merged commit 22b7dda into microsoft:main Aug 29, 2024
470 of 471 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Proposed by non-MSFT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants