[X86-64] Only treat PC-relative globals as memory content if they are dynamically relocated #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-fink
force-pushed
the
bugfix/pcrel-mem-access
branch
2 times, most recently
from
7a6f9c2 to
04c32ab
Compare
martin-fink
force-pushed
the
bugfix/pcrel-mem-access
branch
from
04c32ab to
bd633cb
Compare
aaronsm
reviewed
Dec 27, 2021
… dynamically relocated This makes sure that both of the following work as expected: 1. mov eax, [rip + myglob@GOTPCREL] used for shared libraries compiled to position independent code (-fPIC) Here myglob is dynamically relocated through the GOT 2. mov eax, [rip + myglob] used for non-PIC code to access a global directly without any indirection through the GOT [Test] Added one test to verify RIP-relative globals work as expected
martin-fink
force-pushed
the
bugfix/pcrel-mem-access
branch
from
bd633cb to
0fc6971
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that both of the following work as expected:
mov eax, [rip + myglob@GOTPCREL]used for shared libraries compiled to position independent code (-fPIC). Here myglob is dynamically relocated through the GOT
mov eax, [rip + myglob]used for non-PIC code to access a global directly without any indirection through the GOT
The added test verifies that 2. works, which was broken previously (the code would print the address of
iinstead of its value). The testsglobalvar-test.cand dhrystone verify that 1. works as expected.I've implemented this by adding a set that keeps track of global variables that have
DynRelocType == ELF::R_X86_64_GLOB_DAT.