Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Upgrade pytorch to 2.4.1 #784

Merged
merged 3 commits into from
Oct 16, 2024
Merged

[CI] Upgrade pytorch to 2.4.1 #784

merged 3 commits into from
Oct 16, 2024

Conversation

mshr-h
Copy link
Collaborator

@mshr-h mshr-h commented Jul 25, 2024

As per title.

@mshr-h mshr-h mentioned this pull request Jul 25, 2024
@mshr-h mshr-h force-pushed the upgrade-torch-24 branch 3 times, most recently from cb6616c to e15721e Compare August 14, 2024 09:58
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.52%. Comparing base (ccc3ada) to head (7e7015a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #784   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files          76       76           
  Lines        4625     4625           
  Branches      741      741           
=======================================
  Hits         4048     4048           
  Misses        375      375           
  Partials      202      202           
Flag Coverage Δ
unittests 87.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mshr-h mshr-h changed the title [CI] Upgrade pytorch to 2.4 [CI] Upgrade pytorch to 2.3 Oct 10, 2024
@mshr-h mshr-h marked this pull request as ready for review October 15, 2024 10:49
@mshr-h mshr-h marked this pull request as draft October 15, 2024 11:18
@mshr-h
Copy link
Collaborator Author

mshr-h commented Oct 15, 2024

We can avoid the below error with updating onnx opset 11->13.

FAILED tests/test_onnxml_linear_converter.py::TestONNXLinear::test_logistic_regression_onnxml_binary - onnxruntime.capi.onnxruntime_pybind11_state.RuntimeException: [ONNXRuntimeError] : 6 : RUNTIME_EXCEPTION : Non-zero status code returned while running Reshape node. Name:'/_operators.0/Reshape' Status Message: /onnxruntime_src/onnxruntime/core/providers/cpu/tensor/reshape_helper.h:44 onnxruntime::ReshapeHelper::ReshapeHelper(const onnxruntime::TensorShape&, onnxruntime::TensorShapeVector&, bool) input_shape_size == size was false. The input tensor cannot be reshaped to the requested shape. Input shape:{100}, requested shape:{1}

@mshr-h mshr-h changed the title [CI] Upgrade pytorch to 2.3 [WIP][CI] Upgrade pytorch to 2.3/2.4 Oct 15, 2024
@mshr-h mshr-h force-pushed the upgrade-torch-24 branch 3 times, most recently from 4811f1f to 80afcb1 Compare October 16, 2024 00:53
@mshr-h mshr-h marked this pull request as ready for review October 16, 2024 02:50
@mshr-h
Copy link
Collaborator Author

mshr-h commented Oct 16, 2024

@ksaur Can you take a look at it? Thanks!

@mshr-h mshr-h changed the title [WIP][CI] Upgrade pytorch to 2.3/2.4 [WIP][CI] Upgrade pytorch to 2.4.1 Oct 16, 2024
@mshr-h mshr-h changed the title [WIP][CI] Upgrade pytorch to 2.4.1 [CI] Upgrade pytorch to 2.4.1 Oct 16, 2024
Copy link
Contributor

@ksaur ksaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! :)

@ksaur ksaur merged commit c5186d8 into main Oct 16, 2024
11 checks passed
@ksaur ksaur deleted the upgrade-torch-24 branch October 16, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants