Skip to content

Commit

Permalink
build-git-installers.yml: drop cv2pdb exist test
Browse files Browse the repository at this point in the history
Since rainers/cv2pdb#66, the cv2pdb tool no
longer needs assistance to locate the mspdb140.dll library, as it now
uses `vswhere` which is found on all hosted runners.

For Windows/ARM64 builds we're using self-hosted (1ES pool) runners
which may not have `vswhere`, _but_ this is OK since the clang builds
can produce PDBs natively anyway.

Signed-off-by: Matthew John Cheetham <[email protected]>
  • Loading branch information
mjcheetham committed Dec 12, 2024
1 parent 2dc56ed commit be09498
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/build-git-installers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,6 @@ jobs:
# Make sure that there is a `/usr/bin/git` that can be used by `makepkg-mingw`
printf '#!/bin/sh\n\nexec /mingw64/bin/git.exe "$@"\n' >/usr/bin/git &&
# Restrict `PATH` to MSYS2 and to Visual Studio (to let `cv2pdb` find the relevant DLLs)
PATH="/mingw64/bin:/usr/bin:/C/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64:/C/Windows/system32"
type -p mspdb140.dll || exit 1
sh -x /usr/src/build-extra/please.sh build-mingw-w64-git --only-64-bit --build-src-pkg -o artifacts HEAD &&
if test -n "$GPGKEY"
then
Expand Down

0 comments on commit be09498

Please sign in to comment.