feat(tools): add exports map support to migrate-converged-pkg generator #25033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
changed the title
Hotell
changed the title
📊 Bundle size reportUnchanged fixtures
|
3 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cad57a7:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: da8a1d4d97efdb6d95818b605136415d9428e811 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1286 | 1257 | 5000 | |
| Button | mount | 929 | 908 | 5000 | |
| FluentProvider | mount | 1487 | 1477 | 5000 | |
| FluentProviderWithTheme | mount | 569 | 586 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 540 | 537 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 567 | 579 | 10 | |
| MakeStyles | mount | 1952 | 1945 | 50000 | |
| SpinButton | mount | 2374 | 2350 | 5000 |
Hotell
commented
Sep 30, 2022
| @@ -2,7 +2,7 @@ | |||
| "description": "Separate entrypoint for unstable Fluent UI components", | |||
| "main": "../lib-commonjs/unstable/index.js", | |||
| "module": "../lib/unstable/index.js", | |||
| "typings": "../dist/unstable.d.ts", | |||
| "typings": "./../dist/unstable.d.ts", | |||
There was a problem hiding this comment.
normalizing path with export maps
TristanWatanabe
approved these changes
Sep 30, 2022
GeoffCoxMSFT
pushed a commit
to GeoffCoxMSFT/fluentui
that referenced
this pull request
Oct 3, 2022
…or (microsoft#25033) * feat(tools): add exports map support to migrate-converged-pkg generator * refactor(react-components): normalize relative import for unstable package.json
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
…or (microsoft#25033) * feat(tools): add exports map support to migrate-converged-pkg generator * refactor(react-components): normalize relative import for unstable package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
migration generator doesn't provide setup for exports map
New Behavior
migration generator setups exports map including unstable API if present
Related Issue(s)
Fixes partially #25034