fix(scripts-gulp): resolve type/logic issues after webpack middleware…

… bump
microsoft · Mar 1, 2024 · 3df13aa · 3df13aa
1 parent dcfc184
commit 3df13aa
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/scripts/gulp/src/tasks/docs.ts b/scripts/gulp/src/tasks/docs.ts
@@ -193,7 +193,7 @@ task('serve:docs:hot', async () => {
       WebpackDevMiddleware(compiler, {
         publicPath: webpackConfig.output.publicPath,
         stats: 'errors-warnings',
-      } as WebpackDevMiddleware.Options),
+      } as WebpackDevMiddleware.Options<any, any>),
     );
 
     if (process.env.NODE_ENV !== 'production') {

diff --git a/scripts/gulp/src/tasks/test-dependencies/utils.ts b/scripts/gulp/src/tasks/test-dependencies/utils.ts
@@ -45,12 +45,16 @@ export const prepareWebpackConfig = (options: WebpackOptions) => {
         },
         renderLicenses: modules => {
           modules.forEach(module => {
-            const packageName = module.packageJson.name;
-            const packageVersion = module.packageJson.version;
+            if (module.packageJson) {
+              const packageName = module.packageJson.name;
+              const packageVersion = module.packageJson.version;
 
-            onDependencyPackage(packageName, packageVersion);
+              onDependencyPackage(packageName, packageVersion);
+            } else {
+              console.error('package.json not found');
+            }
 
-            return modules[0].packageJson.name;
+            return modules[0].packageJson?.name;
           });
 
           return '';