Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in DirectionalHint Callout type #3648

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lawrencewin
Copy link
Contributor

@lawrencewin lawrencewin commented Jun 7, 2024

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

There's a typo in the DirectionalHint type for Callout's directionalHint prop, where "bottomLeftEdge" is spelled as "bottonLeftEdge". This PR fixes this so the linter stops spitting an incorrect error.

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@lawrencewin lawrencewin requested a review from a team as a code owner June 7, 2024 21:02
@PPatBoyd PPatBoyd requested a review from Saadnajmi June 7, 2024 21:06
@lawrencewin lawrencewin enabled auto-merge (squash) June 7, 2024 21:21
Copy link
Collaborator

@Saadnajmi Saadnajmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saadnajmi
Copy link
Collaborator

Which.. after that, we'll have to ensure that the change makes it internally and doesn't cause regressions for partners who don't update their bundles..

@lawrencewin lawrencewin disabled auto-merge June 7, 2024 21:30
@PPatBoyd
Copy link
Contributor

Which.. after that, we'll have to ensure that the change makes it internally and doesn't cause regressions for partners who don't update their bundles..

FWIW there are no current users of the enum value that I could find in any Office repos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants