Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding metrics section to budgeting #1101

Open
wants to merge 3 commits into
base: features/mslearn
Choose a base branch
from

Conversation

KevDLR
Copy link
Contributor

@KevDLR KevDLR commented Nov 6, 2024

πŸ› οΈ Description

Adding metrics section to budgeting

Fixes #
N/A

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • 🀏 Lint tests
  • 🀞 PS -WhatIf / az validate
  • πŸ‘ Manually deployed + verified
  • πŸ’ͺ Unit tests
  • πŸ™Œ Integration tests

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Updated changelog (required for dev PRs)
  • ➑️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@microsoft-github-policy-service microsoft-github-policy-service bot added Micro PR πŸ”¬ Very small PR that should be especially easy for newcomers Needs: Review πŸ‘€ PR that is ready to be reviewed labels Nov 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Tool: FinOps guide Implementing FinOps guide label Nov 6, 2024
@flanakin flanakin added this to the Guide - Build-out milestone Nov 7, 2024
@flanakin flanakin added Needs: Attention πŸ‘‹ Issue or PR needs to be reviewed by the author or it will be closed due to no activity and removed Needs: Review πŸ‘€ PR that is ready to be reviewed labels Nov 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Review πŸ‘€ PR that is ready to be reviewed and removed Needs: Attention πŸ‘‹ Issue or PR needs to be reviewed by the author or it will be closed due to no activity labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Micro PR πŸ”¬ Very small PR that should be especially easy for newcomers Needs: Review πŸ‘€ PR that is ready to be reviewed Tool: FinOps guide Implementing FinOps guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants