Exception handled for invalid HTTPVerb with unit testing. (#4714)

Co-authored-by: Alankar Jagtap <[email protected]>

src/Microsoft.Health.Fhir.Api/Resources.resx

@@ -426,4 +426,7 @@
   <data name="MissingInputParams" xml:space="preserve">
     <value>inputParams not found, request body must be a valid Parameters resource.</value>
   </data>
-</root>
+  <data name="InvalidBundleEntryRequest" xml:space="preserve">
+    <value>Requested operation '{0}' is invalid using the request method {1}.</value>
+  </data>
+</root>

src/Microsoft.Health.Fhir.Shared.Api.UnitTests/Features/Resources/Bundle/BundleHandlerTests.cs

@@ -371,6 +371,33 @@ public async Task GivenATransactionBundleRequestWithNullUrl_WhenProcessing_Retur
             await Assert.ThrowsAsync<RequestNotValidException>(async () => await _bundleHandler.Handle(bundleRequest, default));
         }
 
+        [Fact]
+        public async Task GivenATransactionBundleRequestWithNullRequestMethod_WhenProcessing_ReturnsABadRequest()
+        {
+            var bundle = new Hl7.Fhir.Model.Bundle
+            {
+                Type = BundleType.Transaction,
+                Entry = new List<EntryComponent>
+                {
+                    new EntryComponent
+                    {
+                        Request = new RequestComponent
+                        {
+                            Method = null,
+                            Url = "/Patient",
+                        },
+                        Resource = new Basic { Id = "test"},
+                    },
+                },
+            };
+
+            _router.When(r => r.RouteAsync(Arg.Any<RouteContext>()))
+                .Do(RouteAsyncFunction);
+
+            var bundleRequest = new BundleRequest(bundle.ToResourceElement());
+            await Assert.ThrowsAsync<RequestNotValidException>(async () => await _bundleHandler.Handle(bundleRequest, default));
+        }
+
         [Fact]
         public async Task GivenABundle_WhenProcessed_CertainResponseHeadersArePropagatedToOuterResponse()
         {

src/Microsoft.Health.Fhir.Shared.Api/Features/Resources/Bundle/TransactionBundleValidator.cs

@@ -124,6 +124,12 @@ private async Task<string> GetResourceId(EntryComponent entry, IDictionary<strin
         private static bool ShouldValidateBundleEntry(EntryComponent entry)
         {
             string requestUrl = entry.Request?.Url;
+            var requestVerb = entry.Request?.MethodElement?.ObjectValue as string;
+            if (string.IsNullOrWhiteSpace(requestVerb) || !Enum.IsDefined(typeof(HTTPVerb), requestVerb))
+            {
+                throw new RequestNotValidException(string.Format(Api.Resources.InvalidBundleEntryRequest, entry.Request.Url, requestVerb));
+            }
+
             HTTPVerb? requestMethod = entry.Request?.Method;
 
             if (string.IsNullOrWhiteSpace(requestUrl))