-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/0.14.2 #3375
Release/0.14.2 #3375
Conversation
…rosoft#3315) * Eliminate calls with FILE_FLAG_OVERLAPPED set, but no overlapped Signed-off-by: Alan Jowett (from Dev Box) <[email protected]> * PR feedback Signed-off-by: Alan Jowett (from Dev Box) <[email protected]> * PR feedback Signed-off-by: Alan Jowett (from Dev Box) <[email protected]> * PR feedback Signed-off-by: Alan Jowett <[email protected]> --------- Signed-off-by: Alan Jowett (from Dev Box) <[email protected]> Signed-off-by: Alan Jowett <[email protected]> Co-authored-by: Alan Jowett <[email protected]>
* Switch synchronous thread to thread_local storage Signed-off-by: Alan Jowett <[email protected]> * Add dedicated calls to cleanup device handles on thread attach/detach Signed-off-by: Alan Jowett <[email protected]> * Add dedicate test to stress device handling Signed-off-by: Alan Jowett <[email protected]> --------- Signed-off-by: Alan Jowett <[email protected]> Co-authored-by: Alan Jowett <[email protected]>
* fix * add tests * code cleanup * fix tests * cr comments * cr comments
419dcdf
to
d7cb523
Compare
d7cb523
to
30833e1
Compare
3276 is not a bug fix it's an enhancement (it fixes #3275 which is clearly labeled as an enhancement not a bug fix). As such, this is not normally appropriate for cherry picking into a patch release of an already-released version per semantic versioning 2.0 which ebpf-for-windows says it follows. SemVer 2.0 does say
And so you can argue that since x==0 then you can even make breaking changes in a patch release, and that would be true. But the PR description currently does not even explain why one would want to put a non-bug fix into an existing release rather than bumping the minor version number. Please explain, since we should be getting into the habit of NOT doing this. |
Also #3330 seems to be an optimization not a bug fix. |
Description
This patch to v0.14 cherry-picks the following changes from main:
ebpf_id_table
#3276Testing
CI/CD.
Documentation
No.
Installation
No.