Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/0.14.2 #3375

Closed
Closed

Conversation

shankarseal
Copy link
Collaborator

@shankarseal shankarseal commented Mar 22, 2024

Alan-Jowett and others added 5 commits March 22, 2024 00:40
…rosoft#3315)

* Eliminate calls with FILE_FLAG_OVERLAPPED set, but no overlapped

Signed-off-by: Alan Jowett (from Dev Box) <[email protected]>

* PR feedback

Signed-off-by: Alan Jowett (from Dev Box) <[email protected]>

* PR feedback

Signed-off-by: Alan Jowett (from Dev Box) <[email protected]>

* PR feedback

Signed-off-by: Alan Jowett <[email protected]>

---------

Signed-off-by: Alan Jowett (from Dev Box) <[email protected]>
Signed-off-by: Alan Jowett <[email protected]>
Co-authored-by: Alan Jowett <[email protected]>
* Switch synchronous thread to thread_local storage

Signed-off-by: Alan Jowett <[email protected]>

* Add dedicated calls to cleanup device handles on thread attach/detach

Signed-off-by: Alan Jowett <[email protected]>

* Add dedicate test to stress device handling

Signed-off-by: Alan Jowett <[email protected]>

---------

Signed-off-by: Alan Jowett <[email protected]>
Co-authored-by: Alan Jowett <[email protected]>
* fix

* add tests

* code cleanup

* fix tests

* cr comments

* cr comments
@shankarseal shankarseal force-pushed the release/0.14.2 branch 2 times, most recently from 419dcdf to d7cb523 Compare March 22, 2024 08:06
@dthaler
Copy link
Collaborator

dthaler commented Mar 22, 2024

This patch to v0.14 cherry-picks the following changes from main:

#3276

3276 is not a bug fix it's an enhancement (it fixes #3275 which is clearly labeled as an enhancement not a bug fix). As such, this is not normally appropriate for cherry picking into a patch release of an already-released version per semantic versioning 2.0 which ebpf-for-windows says it follows.

SemVer 2.0 does say

Patch version Z (x.y.Z | x > 0) MUST be incremented if only backward compatible bug fixes are introduced.

And so you can argue that since x==0 then you can even make breaking changes in a patch release, and that would be true. But the PR description currently does not even explain why one would want to put a non-bug fix into an existing release rather than bumping the minor version number.

Please explain, since we should be getting into the habit of NOT doing this.

@dthaler
Copy link
Collaborator

dthaler commented Mar 25, 2024

Also #3330 seems to be an optimization not a bug fix.

@shankarseal shankarseal deleted the release/0.14.2 branch March 27, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants