Add support for unlimited map size #3348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3348 +/- ##
==========================================
+ Coverage 83.78% 84.46% +0.68%
==========================================
Files 143 147 +4
Lines 27297 27229 -68
==========================================
+ Hits 22870 22999 +129
+ Misses 4427 4230 -197 ☔ View full report in Codecov by Sentry. |
saxena-anurag
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
dthaler
reviewed
Apr 22, 2024
dthaler
previously approved these changes
Apr 22, 2024
dthaler
dismissed
their stale review
Waiting for other comments to be addressed or at least responded to
dthaler
previously approved these changes
Apr 22, 2024
shpalani
previously approved these changes
Apr 24, 2024
shpalani
approved these changes
Apr 25, 2024
Alan-Jowett
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3328
Description
This PR changes the behavior of the below hash-table based map types, to have unlimited entries. The
max_entriescount in the map definition acts as a hint to the number of buckets to be created when the map is created.Behavior of the below hash-table based maps is not changed:
Testing
Added new tests and updated existing tests to validate the new behavior.
Documentation
NA
Installation
NA