Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor all deployments to use the MSI package. #3284

Merged
merged 64 commits into from
Mar 21, 2024

Conversation

gtrevi
Copy link
Collaborator

@gtrevi gtrevi commented Feb 20, 2024

Closes #1279

Description

This PR updates the installation process for the eBPF component in the CICD pipeline. The previous component-based installation is being replaced with an MSI-based installation for deploying the eBPF platform on the GitHub runners.

With this change, all tests included in the build artifacts will now run in environments identical to those encountered by users who do not clone the entire repository, and just install the MSI. This adjustment also enables prompt identification of any issues stemming from changes made without updating the MSI.

Testing

Local, CICD

Documentation

No.

Installation

No.

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (d7c7af6) to head (e81e017).
Report is 60 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3284      +/-   ##
==========================================
+ Coverage   83.78%   84.47%   +0.69%     
==========================================
  Files         143      147       +4     
  Lines       27297    27213      -84     
==========================================
+ Hits        22870    22988     +118     
+ Misses       4427     4225     -202     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gtrevi gtrevi closed this Mar 12, 2024
@gtrevi gtrevi force-pushed the gtrevi/refactor-all-deployments-with-msi branch from 5fcc30f to 7b1cb3a Compare March 12, 2024 00:06
@gtrevi gtrevi reopened this Mar 12, 2024
dv-msft
dv-msft previously approved these changes Mar 21, 2024
@gtrevi gtrevi requested a review from dv-msft March 21, 2024 03:05
dthaler
dthaler previously approved these changes Mar 21, 2024
@gtrevi gtrevi requested a review from dthaler March 21, 2024 18:34
@gtrevi gtrevi closed this Mar 21, 2024
@gtrevi gtrevi force-pushed the gtrevi/refactor-all-deployments-with-msi branch from 17f3ebc to b494058 Compare March 21, 2024 18:37
@gtrevi gtrevi reopened this Mar 21, 2024
dthaler
dthaler previously approved these changes Mar 21, 2024
@gtrevi gtrevi requested a review from saxena-anurag March 21, 2024 20:59
@gtrevi gtrevi enabled auto-merge March 21, 2024 21:00
@gtrevi gtrevi added this pull request to the merge queue Mar 21, 2024
Merged via the queue into microsoft:main with commit 1eaa568 Mar 21, 2024
80 checks passed
@gtrevi gtrevi deleted the gtrevi/refactor-all-deployments-with-msi branch March 21, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSI file should be tested in CI/CD
5 participants