Update test macro to wok with custom generate_schema_name()
#260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prdpsvs , any chance we could get it merged soon? This is blocking some customers. If you have any feedback I am happy to update the code. |
prdpsvs
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example of updated code to fix #259
This would technically be considered a breaking change so I added a new var called
synapse_test_schemathat people could set totarget.nameif they want to go back to the previous behavior.We could also make it a non-breaking change and make using
generate_schema_name()opt-in rather than opt-out but the new logic feels more correct to me instead of the current one.